Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support $BROWSER envar #8596

Closed
2 tasks
kyoh86 opened this issue Mar 23, 2024 · 5 comments
Closed
2 tasks

Support $BROWSER envar #8596

kyoh86 opened this issue Mar 23, 2024 · 5 comments
Assignees
Labels
closing-soon This issue will automatically close in 4 days unless further comments are made. feature-request A feature should be added or improved. p3 This is a minor priority issue response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. sso

Comments

@kyoh86
Copy link

kyoh86 commented Mar 23, 2024

Describe the feature

I want the BROWSER variable to be referenced when opening the browser with a command such as aws sso login.

Use Case

We use wslview to open our browser in WSL.
However, there are many packages that easily install xdg-open as a dependency even though it is not available in WSL.
I don't want such xdg-open which does not work, to be called, so I set the BROWSER environment variable to "wslview" for various tools, but the AWS CLI ignores this.

Proposed Solution

I would like the following solution.

  • Refer to the BROWSER environment variable
  • Be able to specify the browser command to be used in the AWS CLI configuration file

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CLI version used

aws-cli/2.15.19 Python/3.11.8 Linux/5.15.146.1-microsoft-standard-WSL2 source/x86_64.arch prompt/off

Environment details (OS name and version, etc.)

Arch Linux 5.15.146.1-microsoft-standard-WSL2 x86_64

@kyoh86 kyoh86 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 23, 2024
@amberkushwaha
Copy link

the featured issue in still missing in the file folio for long timr please try to settle the periodic info on it for betterment of the study.

@tim-finnigan tim-finnigan self-assigned this May 10, 2024
@tim-finnigan
Copy link
Contributor

Thanks for the sso login feature request. Have you tried setting BROWSER=wslview aws sso login? Others said in #4715 (comment) that worked.

@tim-finnigan tim-finnigan added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. p3 This is a minor priority issue sso and removed needs-triage This issue or PR still needs to be triaged. labels May 10, 2024
Copy link

Greetings! It looks like this issue hasn’t been active in longer than five days. We encourage you to check if this is still an issue in the latest release. In the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please feel free to provide a comment or upvote with a reaction on the initial post to prevent automatic closure. If the issue is already closed, please feel free to open a new one.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label May 20, 2024
@kyoh86
Copy link
Author

kyoh86 commented May 21, 2024

@tim-finnigan thanks! sorry, I missed. it is supported already.

@kyoh86 kyoh86 closed this as completed May 21, 2024
Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closing-soon This issue will automatically close in 4 days unless further comments are made. feature-request A feature should be added or improved. p3 This is a minor priority issue response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. sso
Projects
None yet
Development

No branches or pull requests

3 participants