Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes error messaging - physical resource id is always required #108

Merged
merged 1 commit into from Aug 20, 2018

Conversation

vmadura
Copy link
Contributor

@vmadura vmadura commented Aug 19, 2018

Fixes #107

Tested using same steps in the reported issue and confirmed that correct error message is being reported:
image

@codecov-io
Copy link

codecov-io commented Aug 19, 2018

Codecov Report

Merging #108 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #108   +/-   ##
=======================================
  Coverage   71.34%   71.34%           
=======================================
  Files          17       17           
  Lines         698      698           
=======================================
  Hits          498      498           
  Misses        156      156           
  Partials       44       44
Impacted Files Coverage Δ
cfn/wrap.go 90% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d0bef9...f0543f4. Read the comment docs.

@bmoffatt
Copy link
Collaborator

Thanks for the fix!

@bmoffatt bmoffatt merged commit f118b75 into aws:master Aug 20, 2018
bmoffatt added a commit to bmoffatt/aws-lambda-go that referenced this pull request Oct 10, 2019
bmoffatt added a commit that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants