Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing 'apiKeyId' to APIGatewayRequestIdentity #235

Merged
merged 2 commits into from Sep 18, 2019

Conversation

nhibberd
Copy link
Contributor

Description of changes: Adding missing apiKeyId to APIGatewayRequestIdentity

Similar issue / changes - aws/serverless-java-container#136
Some documentation that makes reference to apiKeyId - api-gateway-mapping-template-reference

Also happy to add anything that's required to get this through

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Sep 17, 2019

Codecov Report

Merging #235 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #235   +/-   ##
=======================================
  Coverage   74.44%   74.44%           
=======================================
  Files          20       20           
  Lines         677      677           
=======================================
  Hits          504      504           
  Misses        128      128           
  Partials       45       45

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02a2e04...a52b111. Read the comment docs.

@bmoffatt bmoffatt merged commit 1a58586 into aws:master Sep 18, 2019
@bmoffatt
Copy link
Collaborator

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants