Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-lambda-zip: pass pointer to cli.StringFlag instead of value #249

Merged
merged 1 commit into from Nov 13, 2019

Conversation

bmoffatt
Copy link
Collaborator

Issue #, if available:

#248

Description of changes:

Without this change, the following compile error is seen when installing build-lambda-zip using go get

$ go get -u github.com/bmoffatt/aws-lambda-go/cmd/build-lambda-zip
# github.com/bmoffatt/aws-lambda-go/cmd/build-lambda-zip
go/src/github.com/bmoffatt/aws-lambda-go/cmd/build-lambda-zip/main.go:19:17: cannot use cli.StringFlag literal (type cli.StringFlag) as type cli.Flag in array or slice literal:
	cli.StringFlag does not implement cli.Flag (Apply method has pointer receiver)

after pushing this change to my fork go get -u github.com/bmoffatt/aws-lambda-go/cmd/build-lambda-zip works as expected

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Nov 13, 2019

Codecov Report

Merging #249 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #249   +/-   ##
=======================================
  Coverage   74.59%   74.59%           
=======================================
  Files          20       20           
  Lines         681      681           
=======================================
  Hits          508      508           
  Misses        128      128           
  Partials       45       45

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5b7267...db59a3d. Read the comment docs.

@bmoffatt bmoffatt merged commit d226cc1 into aws:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants