-
Notifications
You must be signed in to change notification settings - Fork 561
support for HTTP api gateway #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
=======================================
Coverage 74.63% 74.63%
=======================================
Files 20 20
Lines 682 682
=======================================
Hits 509 509
Misses 128 128
Partials 45 45 Continue to review full report at Codecov.
|
Renamed the struct to APIGatewayV2Request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change should also have a simple de-serialization test case with sample data in https://github.com/aws/aws-lambda-go/blob/master/events/apigw_test.go
There's a sample payload in the docs
Added test case |
Had a chat with one of the gateway devs, who pointed out that the shape of Authorizer wouldn't be extensible for future shapes of authorizers
@bmoffatt Is the next release version come soon with these changes or there is an schedule date for release? |
@shashank-sachan i've released this change today as v1.16.0 - Enjoy! |
Thanks @bmoffatt |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.