Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for HTTP api gateway #274

Merged
merged 14 commits into from Mar 27, 2020
Merged

support for HTTP api gateway #274

merged 14 commits into from Mar 27, 2020

Conversation

shashank-sachan
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Mar 25, 2020

Codecov Report

Merging #274 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #274   +/-   ##
=======================================
  Coverage   74.63%   74.63%           
=======================================
  Files          20       20           
  Lines         682      682           
=======================================
  Hits          509      509           
  Misses        128      128           
  Partials       45       45

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd65554...ad89606. Read the comment docs.

events/apigw.go Outdated Show resolved Hide resolved
events/apigw.go Outdated Show resolved Hide resolved
@shashank-sachan
Copy link
Contributor Author

Renamed the struct to APIGatewayV2Request

events/apigw.go Outdated Show resolved Hide resolved
events/apigw.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@bmoffatt bmoffatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should also have a simple de-serialization test case with sample data in https://github.com/aws/aws-lambda-go/blob/master/events/apigw_test.go

There's a sample payload in the docs

@shashank-sachan
Copy link
Contributor Author

Added test case

events/apigw.go Outdated Show resolved Hide resolved
events/apigw.go Outdated Show resolved Hide resolved
Had a chat with one of the gateway devs, who pointed out that the shape of Authorizer wouldn't be extensible for future shapes of authorizers
@bmoffatt bmoffatt merged commit 8375058 into aws:master Mar 27, 2020
@shashank-sachan
Copy link
Contributor Author

@bmoffatt Is the next release version come soon with these changes or there is an schedule date for release?

@bmoffatt
Copy link
Collaborator

@shashank-sachan i've released this change today as v1.16.0 - Enjoy!

@shashank-sachan
Copy link
Contributor Author

@shashank-sachan i've released this change today as v1.16.0 - Enjoy!

Thanks @bmoffatt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants