Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nested structure definitions for APIGatewayV2HTTPRequestContext #278

Merged
merged 3 commits into from Apr 2, 2020
Merged

Remove nested structure definitions for APIGatewayV2HTTPRequestContext #278

merged 3 commits into from Apr 2, 2020

Conversation

ewbankkit
Copy link
Contributor

Issue #, if available:
Closes #276.

Description of changes:
Removes nested structure definitions for APIGatewayV2HTTPRequestContext.

$ go test ./events/
ok  	github.com/aws/aws-lambda-go/events	0.026s

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Apr 2, 2020

Codecov Report

Merging #278 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #278   +/-   ##
=======================================
  Coverage   74.51%   74.51%           
=======================================
  Files          13       13           
  Lines         624      624           
=======================================
  Hits          465      465           
  Misses        121      121           
  Partials       38       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18b6069...63ae1b5. Read the comment docs.

}

// APIGatewayV2HTTPRequestContextAuthorizerDescription contains authorizer information for the request context.
type APIGatewayV2HTTPRequestContextAuthorizerDescription struct {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Description suffix was copied from the corresponding .NET definition.

Jwt -> JWT
Http -> HTTP
@bmoffatt
Copy link
Collaborator

bmoffatt commented Apr 2, 2020

Thanks for the PR! I pushed a change to the capitalization.

updated the comments too
@bmoffatt bmoffatt merged commit 7836caa into aws:master Apr 2, 2020
@ewbankkit ewbankkit deleted the issue-276 branch April 2, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested event structure definitions cause downstream code generation problems
3 participants