Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag optional API Gateway v2 HTTP Request fields with 'omitempty' #285

Merged
merged 2 commits into from Apr 22, 2020
Merged

Tag optional API Gateway v2 HTTP Request fields with 'omitempty' #285

merged 2 commits into from Apr 22, 2020

Conversation

ewbankkit
Copy link
Contributor

Issue #, if available:
Closes #284.

Description of changes:
When testing with a minimal (GET /) HTTP request through an API Gateway v2 API some fields are optional and should be tagged with omitempty:

  • cookies
  • queryStringParameters
  • pathParameters
  • stageVariables
  • body
  • requestContext.authorizer

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Apr 22, 2020

Codecov Report

Merging #285 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #285   +/-   ##
=======================================
  Coverage   74.51%   74.51%           
=======================================
  Files          13       13           
  Lines         624      624           
=======================================
  Hits          465      465           
  Misses        121      121           
  Partials       38       38           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 235b78e...19a906b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Gateway v2 HTTP request optional fields - tag with omitempty
3 participants