Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIGatewayProxyRequestContext: Add new fields #293

Merged
merged 5 commits into from May 20, 2020
Merged

APIGatewayProxyRequestContext: Add new fields #293

merged 5 commits into from May 20, 2020

Conversation

RaeesBhatti
Copy link
Contributor

Issue #, if available:
Fixes: #292
Description of changes:
Add two new fields DomainName and DomainPrefix to APIGatewayProxyRequestContext

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@RaeesBhatti RaeesBhatti marked this pull request as draft May 15, 2020 06:33
@codecov-io
Copy link

codecov-io commented May 15, 2020

Codecov Report

Merging #293 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #293   +/-   ##
=======================================
  Coverage   74.51%   74.51%           
=======================================
  Files          13       13           
  Lines         624      624           
=======================================
  Hits          465      465           
  Misses        121      121           
  Partials       38       38           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e5ba49...0082a9a. Read the comment docs.

@RaeesBhatti RaeesBhatti marked this pull request as ready for review May 15, 2020 14:59
@bmoffatt
Copy link
Collaborator

Thanks for adding these!

@bmoffatt bmoffatt merged commit c67fade into aws:master May 20, 2020
@RaeesBhatti RaeesBhatti deleted the patch-1 branch May 20, 2020 16:49
@RaeesBhatti
Copy link
Contributor Author

@bmoffatt Can you please publish a new version with these changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

APIGatewayProxyRequestContext is missing DomainName and DomainPrefix
3 participants