Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/build-lambda-zip: Produce valid .zips for provided runtime functions #307

Merged
merged 3 commits into from Jul 15, 2020

Conversation

bmoffatt
Copy link
Collaborator

Description of changes:

This is a follow-up to #298, which added support for using Go with the provided runtime. This change updates the build-lambda-zip tool.

In addition to making the first argument executable, a symlink named "bootstrap" will also be placed in the root of the .zip file, and will point to the executable.

doc reference: https://docs.aws.amazon.com/lambda/latest/dg/runtimes-custom.html

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bmoffatt bmoffatt requested a review from carlzogh July 10, 2020 09:05
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2020

Codecov Report

Merging #307 into master will decrease coverage by 3.59%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
- Coverage   77.66%   74.06%   -3.60%     
==========================================
  Files          17       18       +1     
  Lines         761      833      +72     
==========================================
+ Hits          591      617      +26     
- Misses        116      152      +36     
- Partials       54       64      +10     
Impacted Files Coverage Δ
cmd/build-lambda-zip/main.go 36.11% <44.44%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d109eb...db2cb63. Read the comment docs.

cmd/build-lambda-zip/main.go Outdated Show resolved Hide resolved
cmd/build-lambda-zip/main_test.go Outdated Show resolved Hide resolved
cmd/build-lambda-zip/main_test.go Outdated Show resolved Hide resolved
@bmoffatt bmoffatt merged commit 0b4291a into aws:master Jul 15, 2020
@bmoffatt bmoffatt deleted the build-lambda-zip-provided branch July 15, 2020 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants