Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing request ID to context in norpc mode #313

Merged
merged 2 commits into from Aug 13, 2020

Conversation

MattWhelan
Copy link
Contributor

When self-hosting a Go lambda, the Request ID was missing from the invocation context.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2020

Codecov Report

Merging #313 into master will increase coverage by 0.39%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
+ Coverage   74.06%   74.46%   +0.39%     
==========================================
  Files          18       18              
  Lines         833      834       +1     
==========================================
+ Hits          617      621       +4     
+ Misses        152      150       -2     
+ Partials       64       63       -1     
Impacted Files Coverage Δ
lambda/invoke_loop.go 74.54% <100.00%> (+6.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eebb995...1bffa40. Read the comment docs.

When self-hosting a Go lambda, the Request ID was missing
from the invocation context.
@bmoffatt
Copy link
Collaborator

Thanks for catching this! I'm adding a test case to this PR before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants