Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Amazon MSK event structure #316

Merged
merged 4 commits into from Oct 3, 2020
Merged

Add Amazon MSK event structure #316

merged 4 commits into from Oct 3, 2020

Conversation

ewbankkit
Copy link
Contributor

Closes #315.

Adds Amazon MSK event structures.

$ go test ./events/
ok  	github.com/aws/aws-lambda-go/events	0.020s

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2020

Codecov Report

Merging #316 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #316   +/-   ##
=======================================
  Coverage   72.23%   72.23%           
=======================================
  Files          18       18           
  Lines         724      724           
=======================================
  Hits          523      523           
  Misses        136      136           
  Partials       65       65           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5f1839...b03fe34. Read the comment docs.

events/msk.go Outdated Show resolved Hide resolved
events/msk.go Outdated Show resolved Hide resolved
events/msk.go Outdated Show resolved Hide resolved
events/msk_test.go Outdated Show resolved Hide resolved
@bmoffatt
Copy link
Collaborator

@carlzogh
Copy link
Contributor

@carlzogh should we name this KafaEvent instead to match the java library?

ref: https://github.com/aws/aws-lambda-java-libs/blob/master/aws-lambda-java-events/src/main/java/com/amazonaws/services/lambda/runtime/events/KafkaEvent.java

Yes I think we should name it KafkaEvent to stay consistent.

@ewbankkit
Copy link
Contributor Author

Renaming done.

@bmoffatt bmoffatt merged commit 406b8fc into aws:master Oct 3, 2020
@ewbankkit ewbankkit deleted the add-msk-event-source branch October 3, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Amazon MSK events
4 participants