Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ECR Image Scan Event #378

Merged
merged 5 commits into from Jul 15, 2021
Merged

Adding ECR Image Scan Event #378

merged 5 commits into from Jul 15, 2021

Conversation

alvinsiew
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@alvinsiew alvinsiew changed the title Ecr scan events Adding ECR Scan Event May 22, 2021
@alvinsiew alvinsiew changed the title Adding ECR Scan Event Adding ECR Image Scan Event May 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2021

Codecov Report

Merging #378 (fc8c51d) into master (cd5ccc1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #378   +/-   ##
=======================================
  Coverage   72.22%   72.22%           
=======================================
  Files          19       19           
  Lines         738      738           
=======================================
  Hits          533      533           
  Misses        138      138           
  Partials       67       67           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd5ccc1...fc8c51d. Read the comment docs.

Copy link
Collaborator

@bmoffatt bmoffatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments are on the type names only, structure and tests look correct when compared with the docs: https://docs.aws.amazon.com/AmazonECR/latest/userguide/ecr-eventbridge.html

events/ecr_scan.go Outdated Show resolved Hide resolved
events/ecr_scan.go Outdated Show resolved Hide resolved
events/ecr_scan.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@bmoffatt bmoffatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bmoffatt bmoffatt merged commit 99b35f2 into aws:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants