Add API Gateway V2 custom authorizer simple response type #386
Conversation
dirknilius
changed the title
events/apigw.go
Outdated
| // APIGatewayV2CustomAuthorizerSimpleResponse represents the simple format of an API Gateway V2 authorization response. | ||
| type APIGatewayV2CustomAuthorizerSimpleResponse struct { | ||
| IsAuthorized bool `json:"isAuthorized"` | ||
| Context map[string]interface{} `json:"context"` |
There was a problem hiding this comment.
Did you get a chance to verify this works as expected with a context set and without it set (using the default value). I just wonder what happens if Context is nil (null in json) and/or an empty map ({} in json)
There was a problem hiding this comment.
Yes, already using it in production for a while. Works with or without context. So the API accepts the input. But I could check what’s exactly generated and if it makes sense to add omitempty.
There was a problem hiding this comment.
It might make sense and save just a few bytes over the long run so if you could check that would be great
There was a problem hiding this comment.
Hey @harrisonhjones, I just added the tests. Pls take a look if I covered everything.
There was a problem hiding this comment.
BTW, I also added the omitempty flag, as the results are more reasonable.
dirknilius
force-pushed
the
feature/http-api-v2-simple-response
branch
from
291457d
to
13d994a
Compare
dirknilius
force-pushed
the
feature/http-api-v2-simple-response
branch
from
13d994a
to
6630aa2
Compare
|
@bmoffatt or someone else on the Lambda team would need to merge it in. |
Issue #369, #372:
Description of changes:
This PR adds the missing type for API Gateway V2 custom authorizer simple response. See: https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-lambda-authorizer.html#http-api-lambda-authorizer.payload-format-response
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.