Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable stylecheck linter #396

Merged
merged 5 commits into from Sep 17, 2021
Merged

enable stylecheck linter #396

merged 5 commits into from Sep 17, 2021

Conversation

bmoffatt
Copy link
Collaborator

@bmoffatt bmoffatt commented Sep 17, 2021

Description of changes:

I give a lot of feedback on field naming consistency - enabling and configuring the stylecheck linter will help capture the majority of this feedback automatically

This required back-filling //nolint: stylecheck into all the places where there was an inconsistency that can't be fixed without breaking API compatibility

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2021

Codecov Report

Merging #396 (2682cc2) into main (f9e86f1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #396   +/-   ##
=======================================
  Coverage   71.63%   71.63%           
=======================================
  Files          19       19           
  Lines        1040     1040           
=======================================
  Hits          745      745           
  Misses        228      228           
  Partials       67       67           
Impacted Files Coverage Δ
events/attributevalue.go 78.26% <ø> (ø)
events/code_commit.go 28.12% <ø> (ø)
events/s3.go 50.00% <ø> (ø)
lambda/runtime_api_client.go 73.13% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9e86f1...2682cc2. Read the comment docs.

@bmoffatt bmoffatt requested a review from iph September 17, 2021 23:23
@iph
Copy link
Collaborator

iph commented Sep 17, 2021

beautiful linting :')

@bmoffatt bmoffatt merged commit 1ba09af into aws:main Sep 17, 2021
@bmoffatt bmoffatt deleted the stylecheck branch September 17, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants