Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APIGatewayv2 Lambda Authorizer support in events #399

Merged
merged 10 commits into from Mar 29, 2022

Conversation

tjames-stig
Copy link
Contributor

Issue #, if available:
This addresses #394, which really is more of a symptom of not having purpose-built struct definitions for authorizers for HTTP API Gateway.

Description of changes:
apigw.go did not have any purpose-built struct definitions available for use for apigatewayv2 HTTP Lambda Authorizers, so I've added struct definitions for the V1 and V2 payloads for apigatewayv2 Lambda Authorizer requests, as well as the IAM Policy response payload.

I've tested the V2 request payload, as that is what I have code written in place for, but I have not yet tested the V1 request payload or the IAM policy response payload. For all struct definitions, I followed the documentation found at the http api lambda authorizer documentation.

I've attempted to reuse other structure definitions and follow what appeared to be the pre-existing naming convention for type names. I believe this is more or less what support for HTTP Lambda Authorizers should look like, but there will likely need to be some adjustments and tinkering made to naming and member ordering.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tjames-stig tjames-stig changed the title add authorizer structs to apigw.go Add APIGatewayv2 Lambda Authorizer support in events Oct 7, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2021

Codecov Report

Merging #399 (366b3c1) into main (1900022) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #399   +/-   ##
=======================================
  Coverage   71.42%   71.42%           
=======================================
  Files          19       19           
  Lines        1050     1050           
=======================================
  Hits          750      750           
  Misses        232      232           
  Partials       68       68           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1900022...366b3c1. Read the comment docs.

@menego
Copy link

menego commented Mar 28, 2022

@tjames-stig I see that the merge is blocked by a simple lint error, I hope you can find the time to fix it soon :-)

@tjames-stig
Copy link
Contributor Author

This PR now passes my fork's workflows.

menego
menego previously approved these changes Mar 28, 2022
@bmoffatt
Copy link
Collaborator

@bmoffatt bmoffatt merged commit fbba662 into aws:main Mar 29, 2022
@menego
Copy link

menego commented Mar 29, 2022

Hi guys, forgive my ignorance and sorry for asking here but what is the release cycle?
When should this feature be expected to be released?
Is there some doc explaining these?

@bmoffatt
Copy link
Collaborator

@menego I've just tagged v1.29.0, enjoy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants