Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add source-version to additional information in codebuild details #415

Merged
merged 3 commits into from Mar 25, 2022

Conversation

chrispruitt
Copy link
Contributor

This adds the source-version to the CodeBuildEventAdditionalInformation struct. The value is the commit id when the source is github or bitbucket.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2021

Codecov Report

Merging #415 (a553e1b) into main (96ab249) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #415   +/-   ##
=======================================
  Coverage   71.66%   71.66%           
=======================================
  Files          19       19           
  Lines        1041     1041           
=======================================
  Hits          746      746           
  Misses        228      228           
  Partials       67       67           
Impacted Files Coverage Δ
events/codebuild.go 38.46% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96ab249...a553e1b. Read the comment docs.

@bmoffatt
Copy link
Collaborator

bmoffatt commented Jan 7, 2022

LGTM, do you have a reference to the corresponding AWS Docs I can look at to verify? If not that's fine, just need to make some time to trigger the event myself :)

@chrispruitt
Copy link
Contributor Author

I don't. The only docs I found on the codebuild notification event, were only example JSONs that didn't include this field. But I found that it exists when actually consuming codebuild notifications.

https://docs.aws.amazon.com/codebuild/latest/userguide/sample-build-notifications.html

@bmoffatt
Copy link
Collaborator

I was able to verify this by starting a build using the "Start build with overrides" flow in the console.

@bmoffatt bmoffatt merged commit adf9127 into aws:main Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants