Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing BuildNumber to CodeBuildEventAdditionalInformation #417

Merged
merged 7 commits into from Mar 25, 2022
Merged

Add missing BuildNumber to CodeBuildEventAdditionalInformation #417

merged 7 commits into from Mar 25, 2022

Conversation

guiminyao
Copy link
Contributor

@guiminyao guiminyao commented Dec 16, 2021

Issue #, if available:
#413

Description of changes:
Add missing BuildNumber to CodeBuildEventAdditionalInformation struct, and update tests.
SUCCEEDED, FAILED, STOPPED events do have the piece of info, not presented in IN_PROGRESS event.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@guiminyao guiminyao marked this pull request as ready for review December 16, 2021 09:00
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2022

Codecov Report

Merging #417 (24be98f) into main (3afc312) will decrease coverage by 0.23%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
- Coverage   71.66%   71.42%   -0.24%     
==========================================
  Files          19       19              
  Lines        1041     1050       +9     
==========================================
+ Hits          746      750       +4     
- Misses        228      232       +4     
- Partials       67       68       +1     
Impacted Files Coverage Δ
events/codebuild.go 40.90% <44.44%> (+2.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3afc312...24be98f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants