Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit empty fields in CodeBuildPhase #428

Merged
merged 1 commit into from Feb 10, 2022
Merged

Omit empty fields in CodeBuildPhase #428

merged 1 commit into from Feb 10, 2022

Conversation

calavera
Copy link
Contributor

@calavera calavera commented Feb 9, 2022

The last element of a list of phases sent by code build only contains start-time and phase-type, the rest of the fields are missing.

I don't know why it only sends those two fields, but I've confirmed this with the CodeBuild folks.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The last element of a list of phases sent by code build only contains `start-time` and `phase-type`, the rest of the fields are missing.

I don't know why it only sends those two fields, but I've confirmed this with the CodeBuild folks.
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2022

Codecov Report

Merging #428 (51c8561) into main (e7ef344) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #428   +/-   ##
=======================================
  Coverage   71.66%   71.66%           
=======================================
  Files          19       19           
  Lines        1041     1041           
=======================================
  Hits          746      746           
  Misses        228      228           
  Partials       67       67           
Impacted Files Coverage Δ
events/codebuild.go 38.46% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7ef344...51c8561. Read the comment docs.

@calavera
Copy link
Contributor Author

@carlzogh I don't have permissions to merge my own PRs here 🤣 do you mind merging this and #427? 🙏

@bmoffatt bmoffatt merged commit 507ad66 into aws:main Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants