Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Add path field in request context struct #432

Merged
merged 2 commits into from Mar 29, 2022
Merged

Feature/Add path field in request context struct #432

merged 2 commits into from Mar 29, 2022

Conversation

thiagoyeds
Copy link
Contributor

Issue #, if available: no created issue

Description of changes: add path field in APIGatewayProxyRequestContext

According to the doc seen here, the lambda function input coming from API Gateway has the "path" field inside "requestContext".

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@thiagoyeds
Copy link
Contributor Author

@felipemarinho97 follow this with me

@thiagoyeds
Copy link
Contributor Author

@carlzogh @bmoffatt Could you help us with this request?

@bmoffatt
Copy link
Collaborator

@thiagoyeds The test data needs to be updated too

@thiagoyeds
Copy link
Contributor Author

@bmoffatt updated tests :)

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

Merging #432 (795a6ee) into main (3afc312) will decrease coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
- Coverage   71.66%   71.42%   -0.24%     
==========================================
  Files          19       19              
  Lines        1041     1050       +9     
==========================================
+ Hits          746      750       +4     
- Misses        228      232       +4     
- Partials       67       68       +1     
Impacted Files Coverage Δ
lambda/rpc.go 62.50% <0.00%> (ø)
events/codebuild.go 40.90% <0.00%> (+2.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3afc312...795a6ee. Read the comment docs.

@bmoffatt bmoffatt merged commit bc1ec47 into aws:main Mar 29, 2022
@thiagoyeds thiagoyeds deleted the feat/add-request-context-path branch March 29, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants