Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, update go to 1.18 #435

Merged
merged 1 commit into from Mar 29, 2022
Merged

Update dependencies, update go to 1.18 #435

merged 1 commit into from Mar 29, 2022

Conversation

carlzogh
Copy link
Contributor

@carlzogh carlzogh commented Mar 28, 2022

Description of changes:
Housekeeping - ran:

  1. go list -m -u all
  2. go get github.com/urfave/cli/v2@v2.4.0
  3. go mod tidy

Also updated go version in go.mod from 1.12 to 1.18

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

keshayad
keshayad previously approved these changes Mar 28, 2022
Copy link
Contributor

@keshayad keshayad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@carlzogh carlzogh changed the title Update dependencies, update go to 1.17 Update dependencies, update go to 1.18 Mar 28, 2022
@carlzogh carlzogh requested a review from keshayad March 28, 2022 12:20
@@ -1,11 +1,16 @@
module github.com/aws/aws-lambda-go

go 1.12
go 1.18
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this break any consumers still using older versions? There's no code changes in this package that require a new minimum version but am thinking about if module aware go get on version 1.12 -> 1.17 is gonna complain about this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess it'll be fine 🤷‍♂️

testing:

pushed this: https://github.com/bmoffatt/test/blob/4225d22556144454019816fa24ec561f3b77924e/go.mod#L3

then did this:

~/test2
$ go version
go version go1.17.8 darwin/amd64
~/test2
$ cat main.go
package main

import (
	"log"

	"github.com/bmoffatt/test"
)

func main() {
	log.Print(test.Test())
}
~/test2
$ go mod init test-test-test
go: creating new go.mod: module test-test-test
go: to add module requirements and sums:
	go mod tidy
~/test2
$ go mod tidy
go: finding module for package github.com/bmoffatt/test
go: found github.com/bmoffatt/test in github.com/bmoffatt/test v0.0.0-20220329001020-4225d2255614
~/test2
$ go run ./main.go
2022/03/28 17:14:22 test

@bmoffatt bmoffatt merged commit d1a6fb3 into aws:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants