Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation fails for react version 18.2.0 #717

Closed
hemalgadhiya opened this issue Sep 22, 2022 · 2 comments
Closed

Installation fails for react version 18.2.0 #717

hemalgadhiya opened this issue Sep 22, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@hemalgadhiya
Copy link

Describe the bug
The installation fails for react version 18.2.0

Versions
Which version of aws-northstar npm package is installed?
version 1.3.18

Screenshots
If applicable, add screenshots to help explain your problem.
Screen Shot 2022-09-22 at 12 02 52 PM

Desktop (please complete the following information):

  • OS: MacOs
  • Browser [e.g. chrome, safari] Chrome
  • Version [e.g. 22]
@hemalgadhiya hemalgadhiya added the bug Something isn't working label Sep 22, 2022
@jessieweiyi
Copy link
Contributor

jessieweiyi commented Sep 26, 2022

Hi @hemalgadhiya,

This issue is related to breaking changes in the major version 18 of @types/react. Some of the dependencies NorthStar is using are still relying on v17.

See:
@types/react@18 break @types/styled-components
@types/react@18 breaks "everything".

While we are working on NorthStar V2,
please check whether you are using React version 17 and use one of the following temporary fixes to suppress the build error:

  1. use @ts-ignore for the block; or
  2. add resolution to your package.json if you are using yarn:
  "resolutions": {
    "@types/react": "^17",
    "@types/react-dom": "^17"
  },

Thank you.

@hemalgadhiya
Copy link
Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants