Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further Expose Secrets Manager Auto Registration Settings #1205

Open
pwortas opened this issue Mar 25, 2024 · 1 comment
Open

Further Expose Secrets Manager Auto Registration Settings #1205

pwortas opened this issue Mar 25, 2024 · 1 comment
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@pwortas
Copy link

pwortas commented Mar 25, 2024

Currently, configure_secrets_management_auto_registration() only accepts a SubnetSelection when determining which networks to add to the identity auto registration.

In a hybrid environment, we have workers coming up in subnets not managed by RFDK or not in AWS at all. It would be nice to be able to provide a list of additional CIDR so that we can keep our repo configuration fully in code and not require post-deployment clickops.

Use Case

  1. Deploy an RFDK farm from code.
  2. Add on-prem workers.
  3. Worker subnets require manual configuration of the identity management backend.

Proposed Solution

Add the ability to cumulatively append subnets to the configuration prior to deployment that does not rely on ISubnet or SubnetSelections. A new prop could be possibly constructed that takes a status, a role and the cidr as a string.


This is a 🚀 Feature Request

@pwortas pwortas added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 25, 2024
@jusiskin
Copy link
Contributor

Thanks for submitting this feature request @pwortas. This seems like a useful enhancement for RFDK users. We have added this to our backlog and report here when we have updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

2 participants