Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INIParseError if separators (i.e. [ and ]) are used in values #3958

Closed
3 tasks done
snorwin opened this issue Jun 15, 2021 · 3 comments · Fixed by #3984
Closed
3 tasks done

INIParseError if separators (i.e. [ and ]) are used in values #3958

snorwin opened this issue Jun 15, 2021 · 3 comments · Fixed by #3984
Labels
bug This issue is a bug.

Comments

@snorwin
Copy link

snorwin commented Jun 15, 2021

Confirm by changing [ ] to [x] below to ensure that it's a bug:

Describe the bug
A clear and concise description of what the bug is.

Version of AWS SDK for Go?
main branch

Version of Go (go version)?
1.6

To Reproduce (observed behavior)

[bar]
foo = ]v]a[l][id
INIParseError: invalid state with ASTKind  and TokenType sep

or

[bar]
foo = v]al[id
INIParseError: expected '['

Expected behavior
Should parse the values which contain separators.

@snorwin snorwin added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jun 15, 2021
@skmcgrail skmcgrail removed the needs-triage This issue or PR still needs to be triaged. label Jun 17, 2021
@skmcgrail
Copy link
Member

@snorwin I know the the AWS CLI allows for these tokens to be present in values. Out of curiosity is there a specific use case that you have that requires support for these tokens in the Go INI config parser, or was this just uncovered while testing the parser with various input?

@snorwin
Copy link
Author

snorwin commented Jun 28, 2021

@skmcgrail the use case is that a dynamic random credential file was generated for a S3 compatible storage by using Go INI and the issue appeared in the velero-plugin-for-aws which uses the AWS SDK to handle S3 connections.

@github-actions
Copy link

github-actions bot commented Jul 1, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

aws-sdk-go-automation pushed a commit that referenced this issue Jul 2, 2021
===

### Service Client Updates
* `service/ec2`: Updates service API
  * This release removes network-insights-boundary
* `service/elasticloadbalancingv2`: Updates service documentation

### SDK Features
* `internal/ini`: The ini parser has been updated to support `[`, `]`, `:`, and `=` being present in section key values. ([#3958](#3958))
aws-sdk-go-automation added a commit that referenced this issue Jul 2, 2021
Release v1.39.0 (2021-07-02)
===

### Service Client Updates
* `service/ec2`: Updates service API
  * This release removes network-insights-boundary
* `service/elasticloadbalancingv2`: Updates service documentation

### SDK Features
* `internal/ini`: The ini parser has been updated to support `[`, `]`, `:`, and `=` being present in section key values. ([#3958](#3958))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants