Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I corrected the log typo at the debug level #2697

Closed
seheonCho opened this issue Jan 12, 2022 · 3 comments
Closed

I corrected the log typo at the debug level #2697

seheonCho opened this issue Jan 12, 2022 · 3 comments
Labels
documentation This is a problem with documentation.

Comments

@seheonCho
Copy link

Describe the bug

I corrected the log typo at the debug level

Expected behavior

aws-java-sdk-s3/src/main/java/com/amazonaws/services/s3/transfer/TransferProgress.java

The correct log needs to be printed out, logger.debug()

log.debug("Number of bytes transferred is more than the actual total bytes to transfer. Total number of bytes to Transfer : "
+ totalBytesToTransfer
+ ". Bytes Transferred : "
+ (bytesTransferred + bytes));

Current behavior

log.debug("Number of bytes transfered is more than the actual total bytes to transfer. Total number of bytes to Transfer : "
                        + totalBytesToTransfer
                        + ". Bytes Transferred : "
                        + (bytesTransferred + bytes));

Steps to Reproduce

It's a simple example.

TransferProgress transferProgress = new TransferProgress();
transferProgress.setTotalBytesToTransfer(1L);
transferProgress.updateProgress(2L);

and if, logging level for project is DEBUG,

We can receive logs with typos output from the following methods.

Possible Solution

log.debug("Number of bytes transferred is more than the actual total bytes to transfer. Total number of bytes to Transfer : "
                        + totalBytesToTransfer
                        + ". Bytes Transferred : "
                        + (bytesTransferred + bytes));

This is my Pull Request

Logs must be stamped with correct words.

Please understand that it is insufficient because it is the first issue preparation and full request. :)

Context

It doesn't affect the operation of the program, but I want the log to be printed correctly.

AWS Java SDK version used

AWS SDK for Java 1.12.92

JDK version used

openJdk 11.0.10

Operating System and version

Window10 , Mac OS Big Sur 11.5.2

@seheonCho seheonCho added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jan 12, 2022
@debora-ito
Copy link
Member

Hi @seheonCho thank you for your contribution. I'll change this to a documentation issue.

For the Java SDK v1 we need to incorporate the changes in our internal repository, so that after the release process they are reflected here in the Github. We'll add your change internally when we have a chance.

@debora-ito debora-ito added documentation This is a problem with documentation. and removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Feb 2, 2022
@seheonCho seheonCho reopened this Feb 2, 2022
@debora-ito
Copy link
Member

The fix was released. Closing.

Copy link

github-actions bot commented Mar 7, 2024

This issue is now closed.

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation.
Projects
None yet
Development

No branches or pull requests

2 participants