Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for setting UserAgent Prefix through environment variable #3000

Open
2 tasks
muthurajr opened this issue Jul 4, 2023 · 1 comment
Open
2 tasks
Labels
feature-request A feature should be added or improved.

Comments

@muthurajr
Copy link

Describe the feature

We are looking at options to prefix UserAgent for s3 client from sdk's. One possible option is change every code like below. This option works but it comes with the risk and time consumption of changing every microservice connecting to s3.

AWSCredentials credentials;
ClientConfiguration conf = new ClientConfiguration()
    .withUserAgentPrefix("APN/1.0 PARTNER/1.0 PRODUCT/1.0");
AmazonS3Client client = new AmazonS3Client(credentials, conf);

Recently, environment variable based user agent setting is introduced in python and ruby SDK's boto/botocore#2955
It would be helpful to implement similar feature in the Java sdk as well.

Use Case

Flexibility to inject User Agent in the existing apps through environment variable, and sync the feature with other language sdk's.

Proposed Solution

boto/botocore#2955

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS Java SDK version used

latest 1.12.501

JDK version used

17.0.7

Operating System and version

alpine 3.18 (latest)

@muthurajr muthurajr added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 4, 2023
@debora-ito
Copy link
Member

Acknowledged.

This has better chances to be implemented in v2 as it's where the team is concentrating most of the effort, and I see you already submitted a feature request - aws/aws-sdk-java-v2#4162.

@debora-ito debora-ito removed the needs-triage This issue or PR still needs to be triaged. label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

2 participants