TransferManager.upload doesn't retain bucketKeyEnabled setting if using multipart upload

[ZhaoMJ]

Upcoming End-of-Support

• I acknowledge the upcoming end-of-support for AWS SDK for Java v1 was announced, and migration to AWS SDK for Java v2 is recommended.

Describe the bug

If multipart upload is used, files uploaded by the TransferManager don't have the correct object-level bucket key setting as specified in the PutObjectRequest.
It turns out that the bucketKeyEnabled setting is not copied when configuring the InitiateMultipartUploadRequest:

aws-sdk-java/aws-java-sdk-s3/src/main/java/com/amazonaws/services/s3/transfer/internal/UploadCallable.java

Lines 422 to 430 in 34b4aa0

	req.withAccessControlList(origReq.getAccessControlList())
	.withRequesterPays(origReq.isRequesterPays())
	.withStorageClass(origReq.getStorageClass())
	.withRedirectLocation(origReq.getRedirectLocation())
	.withSSECustomerKey(origReq.getSSECustomerKey())
	.withSSEAwsKeyManagementParams(origReq.getSSEAwsKeyManagementParams())
	.withGeneralProgressListener(origReq.getGeneralProgressListener())
	.withRequestMetricCollector(origReq.getRequestMetricCollector())
	;

Expected Behavior

Objects uploaded by the TransferManager always have the correct object-level bucket key setting as specified in the PutObjectRequest.

Current Behavior

Objects uploaded by the TransferManager don't have the correct object-level bucket key setting as specified in the PutObjectRequest when multipart upload is used.

Reproduction Steps

1. have a bucket with bucket-level bucket key disabled
2. Create a TransferManager with a MultipartUploadThreshold of 8MB.
3. Upload a file of 12MB using

            PutObjectRequest putObjectRequest = new PutObjectRequest(bucket, key, src)
                    .withSSEAwsKeyManagementParams(sseAwsKeyManagementParams)
                    .withBucketKeyEnabled(true);

4. Verify that S3 bucket key is used for this file.
5. Create another TransferManager with a MultipartUploadThreshold of 16MB.
6. Upload the same file with the same PutObjectRequest using the new TransferManager.
7. Verify that S3 bucket key is not enabled for this file.

Possible Solution

Copy bucketKeyEnabled from PutObjectRequest to InitiateMultipartUploadRequest, i.e. Add the following to UploadCallable.initiateMultipartUpload:

req.withBucketKeyEnabled(origReq.getBucketKeyEnabled())

Additional Information/Context

No response

AWS Java SDK version used

1.12.466

JDK version used

openjdk version "17.0.9" 2023-10-17 LTS OpenJDK Runtime Environment Zulu17.46+19-CA (build 17.0.9+8-LTS) OpenJDK 64-Bit Server VM Zulu17.46+19-CA (build 17.0.9+8-LTS, mixed mode, sharing)

Operating System and version

macOS 13.6.3

[debora-ito]

@ZhaoMJ thank you for raising this. Yes, it looks like bucketKeyEnabled is not being passed to InitiateMultipartUploadRequest. Marking as a bug.

The team's focus is in Java SDK v2 work, so this has low chance to be fixed before the start of Maintenance Mode later this year.