Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug. Circular dependency issue #260

Open
o-alexandrov opened this issue Oct 27, 2021 · 1 comment
Open

Bug. Circular dependency issue #260

o-alexandrov opened this issue Oct 27, 2021 · 1 comment
Labels
good first issue Good for newcomers

Comments

@o-alexandrov
Copy link

Problem

When bundling with rollup, rollup provides with a warning coming from @aws-crypto/crc32.
It affects the resulting bundle size, as it harms tree shaking and depending on the use case might trigger a runtime error.

Full trace (report) is below:

Circular dependency: ../node_modules/@aws-crypto/crc32/build/index.js -> ../node_modules/@aws-crypto/crc32/build/aws_crc32.js -> ../node_modules/@aws-crypto/crc32/build/index.js
Circular dependency: ../node_modules/@aws-crypto/crc32/build/index.js -> ../node_modules/@aws-crypto/crc32/build/aws_crc32.js -> ../node_modules/@aws-crypto/crc32/build/index.js?commonjs-proxy -> ../node_modules/@aws-crypto/crc32/build/index.js

Request

Please remove the circular dependency issue

@seebees seebees added the good first issue Good for newcomers label Dec 9, 2021
@emredarak
Copy link

node_modules/@aws-crypto/crc32/build/index.js -> node_modules/@aws-crypto/crc32/build/aws_crc32.js -> node_modules/@aws-crypto/crc32/build/index.js
node_modules/@aws-crypto/crc32c/build/index.js -> node_modules/@aws-crypto/crc32c/build/aws_crc32c.js -> node_modules/@aws-crypto/crc32c/build/index.js
node_modules/@aws-sdk/credential-provider-ini/dist-es/resolveProfileData.js -> node_modules/@aws-sdk/credential-provider-ini/dist-es/resolveAssumeRoleCredentials.js -> node_modules/@aws-sdk/credential-provider-ini/dist-es/resolveProfileData.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants