Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clients): add @aws-sdk/util-endpoints dependency #4058

Merged
merged 1 commit into from Oct 20, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 19, 2022

Issue

Refs: smithy-lang/smithy-typescript#619

Description

Adds @aws-sdk/util-endpoints dependency in clients which depend on it.

Testing

Verified that clean build with dependencies is successful in client-sesv2

$ aws-sdk-js-v3> git clean -dfx && yarn

$ aws-sdk-js-v3> cd clients/client-sesv2

$ client-sesv2> yarn build:include:deps
...
Done in 136.08s.

Also verified that @aws-sdk/util-endpoints dependency is added in package.json of 15 clients, which imported the dependency in src/endpoint/endpointResolver.ts


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@gwdp
Copy link

gwdp commented Oct 20, 2022

Hi guys, it seems 3.192.0 had a breaking change that was fixed with these changes. Users impacted seem very high as per #4060 comments. Please, release a fix ASAP if possible.

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants