Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): expand custom endpoint type #4097

Merged
merged 1 commit into from Oct 26, 2022
Merged

fix(types): expand custom endpoint type #4097

merged 1 commit into from Oct 26, 2022

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Oct 26, 2022

Issue

#4086

Description

override the type of endpoint in endpoint params to string|Endpoint|EndpointV2 instead of only string

Testing

generated clients

@kuhe kuhe requested a review from a team as a code owner October 26, 2022 15:21
@kuhe kuhe merged commit 3620ce4 into aws:main Oct 26, 2022
@kuhe kuhe deleted the fix/endpoint-type branch October 26, 2022 16:29
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kuhe @trivikr