Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(signature-v4-crt): remove dynamic imports (!) #5225

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Sep 15, 2023

closes #5221
closes #5216
closes #5135
related to #2822 (pin)

removes dynamic imports and checks for aws-crt.

This requires users to install and import @aws-sdk/signature-v4-crt explicitly where before they would only have to install it, and is a slightly breaking change, but would greatly improve the experience around bundlers or strict ESM crashing on the dynamic import.

Currently:

npm i @aws-sdk/signature-v4-crt 
# to be found by dynamic import

Proposed in PR:

npm i @aws-sdk/signature-v4-crt
# will not be found dynamically
require("@aws-sdk/signature-v4-crt");
// This import registers the implementation with signature-v4-multi-region and user-agent-node
// without needing peerDependencies or dynamic imports.
// Without this, the CRT implementation is considered to be unavailable.
// The new error message will say this.

@kuhe kuhe changed the title fix(util-user-agent-node): use import.meta and require.resolve fix(util-user-agent-node): use import() and require.resolve Sep 15, 2023
@kuhe kuhe changed the title fix(util-user-agent-node): use import() and require.resolve fix(signature-v4-crt): remove dynamic imports (!) Sep 18, 2023
@kuhe kuhe force-pushed the chore/crt branch 3 times, most recently from 96356b7 to 1f27302 Compare September 18, 2023 17:04
@kuhe kuhe marked this pull request as draft September 18, 2023 17:04
@kuhe
Copy link
Contributor Author

kuhe commented Oct 4, 2023

  • rewrite S3 ispec to separate browser and Node.js scenarios

@kuhe
Copy link
Contributor Author

kuhe commented Oct 26, 2023

  • integ
  • e2e
  • e2e legacy

@kuhe kuhe marked this pull request as ready for review October 26, 2023 15:06
@kuhe kuhe merged commit 89f97b5 into aws:main Oct 26, 2023
2 checks passed
@kuhe kuhe deleted the chore/crt branch October 26, 2023 15:22
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants