Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): dedupe @aws.protocols#restXml serialization #5568

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

syall
Copy link
Contributor

@syall syall commented Dec 11, 2023

Issue

Issue number, if available, prefixed with "#"

N/A.

Description

What does this implement/fix? Explain your changes.

Codegen for @aws.protocols#restXml serialization was duplicated due to super invocations for payload serialization.

This PR dedupes the serialization by removing the super invocations.

TODO:

  • Generate all clients

Testing

How was this change tested?

CI passes.

Identified affected services:

$ cd codegen/sdk-codegen/aws-models/
$ smithy select --selector "[trait|aws.protocols#restXml]" --allow-unknown-traits .
com.amazonaws.cloudfront#Cloudfront2020_05_31
com.amazonaws.route53#AWSDnsV20130401
com.amazonaws.s3#AmazonS3
com.amazonaws.s3control#AWSS3ControlServiceV20180820

Route53 did not end up having any codegen changes, but CloudFront, S3, and S3 Control did.

Additional context

Add any other context about the PR here.

N/A.

Checklist

  • If you wrote E2E tests, are they resilient to concurrent I/O?
  • If adding new public functions, did you add the @public tag and enable doc generation on the package?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@syall syall changed the title fix(codegen): dedup @aws.protocols#restXml serialization' fix(codegen): dedupe @aws.protocols#restXml serialization' Dec 11, 2023
@syall syall changed the title fix(codegen): dedupe @aws.protocols#restXml serialization' fix(codegen): dedupe @aws.protocols#restXml serialization Dec 11, 2023
@syall syall force-pushed the dedupe-restXml-serialization branch from ade114f to f7bd618 Compare December 11, 2023 21:26
@syall syall marked this pull request as ready for review December 11, 2023 21:27
@syall syall requested a review from a team as a code owner December 11, 2023 21:27
@syall syall merged commit 7df7325 into aws:main Dec 11, 2023
3 checks passed
@syall syall deleted the dedupe-restXml-serialization branch December 12, 2023 01:39
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants