Overlapping definition of string literals

[soulman-is-good]

Describe the bug

Generating typescript from enum shape creates overlapping string literal definitions which renders them useless. No type autocomplete, no type checking works.

aws-sdk-js/scripts/lib/ts-generator.js

Lines 342 to 345 in 49d4c27

	if (Array.isArray(shape.enum)) {
	stringType = shape.enum.map(function(s) {
	return '"' + s + '"';
	}).join('|') + '|' + stringType;

Expected Behavior

Script generates proper string literals from enum shape:

@enum([
    {name: "Pending", value: "Pending"},
    {name: "Failed", value: "Failed"},
    {name: "Success", value: "Success"},
])
string Status

should generate

export type Status = "Pending"|"Failed"|"Success";

Current Behavior

Following structure in smithy:

@enum([
    {name: "Pending", value: "Pending"},
    {name: "Failed", value: "Failed"},
    {name: "Success", value: "Success"},
])
string Status

currently generates following definition file:

export type Status = "Pending"|"Failed"|"Success"|string;

Reproduction Steps

1. have aws-sdk lib installed in the project
2. run node v8 or grater in interactive mode from within the project dir. (just node)
3. paste the following code:

const TSGenerator = require("aws-sdk/scripts/lib/ts-generator");

console.log(new TSGenerator({}).generateTypingsFromShape({}, "Status", {
    "type": "string",
    "enum": [
        "Pending",
        "Failed",
        "Success"
    ]
}));

See the output:

export type Status  = "Pending"|"Failed"|"Success"|string;

Possible Solution

Remove |string; postfix if this is enum, though this is a breaking change and I'm not sure if v3 healed that.

Additional Information/Context

No response

SDK version used

2.1174.0

Environment details (OS name and version, etc.)

MacOS 11.6.6, Amazon Linux 2

[ajredniwja]

Hey thanks for opening this issue, I'll discuss with the team if any possible solutions, I havent tried but it should not be an issue with V3 of the SDK.

[github-actions]

This issue has not received a response in 1 week. If you still think there is a problem, please leave a comment to avoid the issue from automatically closing.

[paul-vd]

Fixed by #4482