Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Opensearch serverless vector search collections - remove default _id #2784

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

kukushking
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Detail

  • Remove redundant _id generation as it is generated by OpenSearch by default.
  • Additionally, passing _id is not supported by OpenSearch vector search collections (see PUT <index>/_create/<id> (for search collection types only):
opensearchpy.helpers.errors.BulkIndexError: ('3 document(s) failed to index.', [{'index': {'_index': 'dummy-vector-search-1', '_id': '32300c88-a52c-4a14-95f6-aad4919b1b7b', 'status': 400, 'error': {'type': 'illegal_argument_exception', 'reason': 'Document ID is not supported in create/index operation request'}, 'data': {'name': 'John'}}}, {'index': {'_index': 'dummy-vector-search-1', '_id': '4c5f5d5d-6337-460f-9efc-31f4c1dd5df1', 'status': 400, 'error': {'type': 'illegal_argument_exception', 'reason': 'Document ID is not supported in create/index operation request'}, 'data': {'name': 'George'}}}, {'index': {'_index': 'dummy-vector-search-1', '_id': '0f924638-c83b-43b1-8c21-de42f6e3a22f', 'status': 400, 'error': {'type': 'illegal_argument_exception', 'reason': 'Document ID is not supported in create/index operation request'}, 'data': {'name': 'Julia'}}}])

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Anton Kukushkin <kukushkin.anton@gmail.com>
@kukushking kukushking added the bug Something isn't working label Apr 22, 2024
@kukushking kukushking self-assigned this Apr 22, 2024
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 598b992
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Signed-off-by: Anton Kukushkin <kukushkin.anton@gmail.com>
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 2c50c44
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: 598b992
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: 2c50c44
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking kukushking merged commit c8b7b03 into main Apr 22, 2024
19 checks passed
@kukushking kukushking deleted the fix/opensearch-serverless-vector-no-id-keys branch April 22, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants