Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to disable checksum_mode #2893

Closed
2 tasks
emilweth opened this issue Aug 9, 2023 · 1 comment · Fixed by #2896
Closed
2 tasks

Add a way to disable checksum_mode #2893

emilweth opened this issue Aug 9, 2023 · 1 comment · Fixed by #2896
Assignees
Labels
feature-request A feature should be added or improved.

Comments

@emilweth
Copy link

emilweth commented Aug 9, 2023

Describe the feature

Add a way to disable x-amz-checksum-mode introduced in 1.132.0

Use Case

Some third party s3 providers does not support x-amz-checksum-mode

Header 'x-amz-checksum-mode' with value '' not implemented (Aws::S3::Errors::NotImplemented)

Proposed Solution

Current workaround is (see mastodon/mastodon#26407)

  if ENV['S3_DISABLE_CHECKSUM_MODE'] == 'true'
    class Aws::S3::FileDownloader
      def validate!
        @params.delete(:checksum_mode)
        super
      end
    end
  end

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

1.132.0

Environment details (OS name and version, etc.)

Dockerized Debian 11.7

@emilweth emilweth added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 9, 2023
@alextwoods alextwoods self-assigned this Aug 9, 2023
@alextwoods alextwoods removed the needs-triage This issue or PR still needs to be triaged. label Aug 9, 2023
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants