Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CognitoIdentityCredentials #2944

Merged
merged 6 commits into from
Nov 14, 2023
Merged

Fix CognitoIdentityCredentials #2944

merged 6 commits into from
Nov 14, 2023

Conversation

jterapin
Copy link
Contributor

@jterapin jterapin commented Nov 10, 2023

This PR addresses the issue mentioned in #2941


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

  1. To make sure we include your contribution in the release notes, please make sure to add description entry for your changes in the "unreleased changes" section of the CHANGELOG.md file (at corresponding gem). For the description entry, please make sure it lives in one line and starts with Feature or Issue in the correct format.

  2. For generated code changes, please checkout below instructions first:
    https://github.com/aws/aws-sdk-ruby/blob/version-3/CONTRIBUTING.md

Thank you for your contribution!

@jterapin
Copy link
Contributor Author

jterapin commented Nov 10, 2023

I plan to tidy up docs and styling on the file but will do it after the team review

@jterapin jterapin marked this pull request as ready for review November 14, 2023 18:45
@alextwoods alextwoods merged commit bd72278 into version-3 Nov 14, 2023
26 checks passed
@mullermp mullermp deleted the fix_cognito_id_creds branch November 17, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants