Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of retracted Brotli package due to downstream dependency #330

Closed
a-h opened this issue Oct 26, 2021 · 0 comments · Fixed by #331
Closed

Use of retracted Brotli package due to downstream dependency #330

a-h opened this issue Oct 26, 2021 · 0 comments · Fixed by #331

Comments

@a-h
Copy link
Contributor

a-h commented Oct 26, 2021

Attempting to get v1.6.0 results in a warning about the brotli package.

$ go get github.com/aws/aws-xray-sdk-go/xray
go: warning: github.com/andybalholm/brotli@v1.0.1: retracted by module author: occasional panics and data corruption
go: to switch to the latest unretracted version, run:
        go get github.com/andybalholm/brotli@latest

This is due to downstream dependency on fasthttp:

$ go mod why github.com/andybalholm/brotli  
# github.com/andybalholm/brotli
# <my package - redacted>
github.com/aws/aws-xray-sdk-go/xray
github.com/valyala/fasthttp
github.com/andybalholm/brotli

fasthttp was updated to use v1.0.2 on the 17th May in this PR:

valyala/fasthttp#1029
valyala/fasthttp@5898006

So, any version after https://github.com/valyala/fasthttp/releases/tag/v1.25.0 would work fine.

A version bump should do it.

a-h added a commit to a-h/aws-xray-sdk-go that referenced this issue Oct 26, 2021
bhautikpip pushed a commit that referenced this issue Oct 27, 2021
* bump fasthttp dependency, fixes #330

* update go.sum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant