-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: 'AddonsStack' missing from environment stack resources. #5791
Comments
Of course I also realize that we might've broken the environment, but I have no idea how. The environment addons stack is still there, all the addons resources (bucket, RDS Instance, etc) are still there, working fine. |
Hey @cristobalmackenzie! To clarify, did you use Copilot to deploy the addons stack initially? (with Copilot v1.32.0, the previous version the environment was deployed with)? It's interesting to me that the |
Hey @dannyrandall ! Yes indeed, we used copilot for everything. I've been looking into it, learning more about CloudFormation and I can't figure out how to replicate this. As far as I understand one shouldn't be able to end up in this state. I did a couple of env deploy / delete with and without the addons folder (I see a couple of delete, delete failed for the addons stack) back in december, and hadn't updated since. It must've been at that time that the stack ended up that way but I can't figure out how. |
Ah ok! I'm wondering if what happened is: the Addons stack failed to delete, but the main stack considered the update a success and therefore removed the Is the existing Addons stack in some kind of |
Related: #5791 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
The existing Addons stack actually appears intact, it consists of a bucket and an RDS instance. There were three attempts at deletion that failed because some exports where in use by other stacks. The addons stack state is UPDATE_COMPLETE. The environment stack though, shows a DELETE_FAILED state for the Addons resource in the Events tab. Subsequent updates to the Addons resource start with CREATE_FAILED, which is when I found this issue. I could manually delete the stack and recreate the whole thing, but I'd like to try and not delete it since its being used daily. If there are no other possible workarounds though, I might not have a choice. I tried to use the Import resource feature of CloudFormation to reincorporate the Addons stack into the environment template but couldn't do it because the template has too many resources that are not supported in the import feature. |
Description:
I'm trying to use
env deploy -n test
to update an environment. I initially wanted just to test there are no changes to the deployed environment and expected the common "there are no changes to deploy, use --force, etc" message.What happened instead was that copilot tried to recreate all my addons, it failed because there are already exports with those names, and then it rolled back.
Details:
I'm running the latest version of copilot (1.33.3), had 1.33.2 before. Same behaviour in both. I believe the last deploy was done with 1.32.0.
This is the output I have from running
copilot env deploy -n test
:This is the output I have from running
copilot env package --diff -n test
:Observed result:
The
--debug
flag mentioned in the issue template doesn't seem to work.Expected result:
I expected the common "there are no changes to deploy" message. I was running that before actually adding more addons.
Debugging:
Looking at the resources for my environment stack, I can see that there isn't a
AddonsStack
resource for my addons. We can also see that in the package diff.The text was updated successfully, but these errors were encountered: