Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove changes done for ORT temporarily misalignment #1240

Closed
avifenesh opened this issue Apr 7, 2024 · 2 comments
Closed

Remove changes done for ORT temporarily misalignment #1240

avifenesh opened this issue Apr 7, 2024 · 2 comments
Assignees
Labels
bug Something isn't working CI CI/CD related
Milestone

Comments

@avifenesh
Copy link
Contributor

Describe the bug

As for today (07/04/24) theres a bug in ORT with new versions of cargo - oss-review-toolkit/ort#8480.
For this issue we added in #1232 a temporary fix which use cargo v1.76 in ORT GH workflow for workaround this issue.
we should track ORT fix for this issue and when fixed remove this temp fix and return to use latest version of cargo.

Expected Behavior

Working with latest stable version of Crago

Current Behavior

Breaking the workflow with Error - NoSuchElementException: Collection contains no element matching the predicate.

Reproduction Steps

Remove Rust chain installing and run the tool

Possible Solution

No response

Additional Information/Context

No response

Client version used

Latest

Redis Version

all

OS

all

Language

TypeScript, Python

Language Version

all

Cluster information

No response

Logs

No response

Other information

No response

@avifenesh avifenesh added bug Something isn't working CI CI/CD related labels Apr 7, 2024
@sschuberth
Copy link

FYI, I've proposed a fix for ORT's Cargo analyzer as part of oss-review-toolkit/ort#8497. I'm positive that it will land in this week's release for ORT (done of Thursdays).

@avifenesh avifenesh self-assigned this Apr 16, 2024
@avifenesh avifenesh added this to the GA milestone Apr 16, 2024
@avifenesh avifenesh changed the title ORT temporarily misalignment with new version of Cargo (1.77 +) Remove changes done for ORT temporarily misalignment Apr 16, 2024
@sschuberth
Copy link

Support for Cargo >= 1.77 has actually been part of ORT release 21.0.0 already. Today's ORT release 22.2.0 on top of that also fixes the regression mentioned in #1350.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI CI/CD related
Projects
None yet
Development

No branches or pull requests

3 participants