Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make timeout commands dynamic: Hardcoded timeout commands need to be processed dynamically #1333

Open
2 tasks
ikolomi opened this issue Apr 24, 2024 · 0 comments

Comments

@ikolomi
Copy link
Contributor

ikolomi commented Apr 24, 2024

Describe the feature

In this PR #1283 we introduce timing out based on the valued passed as a command parameter. This method has to be maintained manually to track new commands that can be introduced in the future. At least we should introduce a test that dynamically validates all commands that have timeout params based on commands.json.
Another, a more optimal approach would be to dynamically generate the parsing code during the build-time, again, based on commands.json.

Use Case

Potential bugs

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

Client version used

pre-GA

Environment details (OS name and version, etc.)

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant