Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 7 commits
- 10 files changed
- 4 contributors
Commits on Jun 3, 2024
Commits on Jun 5, 2024
-
chore(deps): Bump golang.org/x/tools from 0.21.0 to 0.22.0 in /packag…
…es/@jsii/go-runtime-test/project (#4536) Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.21.0 to 0.22.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golang/tools/commit/bc6931db37c33e064504346d9259b3b6d20e13f6"><code>bc6931d</code></a> go.mod: update golang.org/x dependencies</li> <li><a href="https://github.com/golang/tools/commit/1767b144a15d30b79c7744524828fe10bf07a862"><code>1767b14</code></a> go/ssa: remove code with no effect</li> <li><a href="https://github.com/golang/tools/commit/208808308b705255ee693cdc55afe8b4ad37c425"><code>2088083</code></a> internal/gocommand: add more debug info for hanging go commands</li> <li><a href="https://github.com/golang/tools/commit/f1a3b1281e9b5e25fc2f46e88e73023dbb4bbcf0"><code>f1a3b12</code></a> internal/imports: FixImports should be cancellable</li> <li><a href="https://github.com/golang/tools/commit/4478db00aae5c5e487165f6e768681be5d63bac0"><code>4478db0</code></a> go/analysis/passes/copylock: suppress error in ill-typed code</li> <li><a href="https://github.com/golang/tools/commit/018d3b2768ced9f36e90baeb2a542c813dfc28ef"><code>018d3b2</code></a> gopls: warn about Go 1.19 and Go 1.20</li> <li><a href="https://github.com/golang/tools/commit/58cc8a4458597b256f404b4a4a84edc71cd0d00b"><code>58cc8a4</code></a> gopls/internal/filecache: suppress gc in tests</li> <li><a href="https://github.com/golang/tools/commit/b6235391adb3b7f8bcfc4df81055e8f023de2688"><code>b623539</code></a> gopls/internal/cache: suppress "internal" import check on Bazel</li> <li><a href="https://github.com/golang/tools/commit/1e9d12dd1f25735a6fcefd3665be4684ba23fc58"><code>1e9d12d</code></a> go/packages: pass -overlay to all 'go list' invocations</li> <li><a href="https://github.com/golang/tools/commit/3c293ad67a98a86d273bf69c6a742f04a6a367a3"><code>3c293ad</code></a> internal/cache: invalidate broken imports when package files change</li> <li>Additional commits viewable in <a href="https://github.com/golang/tools/compare/v0.21.0...v0.22.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Commits on Jun 7, 2024
-
chore(deps): Bump golang.org/x/tools from 0.21.0 to 0.22.0 in /packag…
…es/@jsii/go-runtime/jsii-runtime-go (#4537) Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.21.0 to 0.22.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golang/tools/commit/bc6931db37c33e064504346d9259b3b6d20e13f6"><code>bc6931d</code></a> go.mod: update golang.org/x dependencies</li> <li><a href="https://github.com/golang/tools/commit/1767b144a15d30b79c7744524828fe10bf07a862"><code>1767b14</code></a> go/ssa: remove code with no effect</li> <li><a href="https://github.com/golang/tools/commit/208808308b705255ee693cdc55afe8b4ad37c425"><code>2088083</code></a> internal/gocommand: add more debug info for hanging go commands</li> <li><a href="https://github.com/golang/tools/commit/f1a3b1281e9b5e25fc2f46e88e73023dbb4bbcf0"><code>f1a3b12</code></a> internal/imports: FixImports should be cancellable</li> <li><a href="https://github.com/golang/tools/commit/4478db00aae5c5e487165f6e768681be5d63bac0"><code>4478db0</code></a> go/analysis/passes/copylock: suppress error in ill-typed code</li> <li><a href="https://github.com/golang/tools/commit/018d3b2768ced9f36e90baeb2a542c813dfc28ef"><code>018d3b2</code></a> gopls: warn about Go 1.19 and Go 1.20</li> <li><a href="https://github.com/golang/tools/commit/58cc8a4458597b256f404b4a4a84edc71cd0d00b"><code>58cc8a4</code></a> gopls/internal/filecache: suppress gc in tests</li> <li><a href="https://github.com/golang/tools/commit/b6235391adb3b7f8bcfc4df81055e8f023de2688"><code>b623539</code></a> gopls/internal/cache: suppress "internal" import check on Bazel</li> <li><a href="https://github.com/golang/tools/commit/1e9d12dd1f25735a6fcefd3665be4684ba23fc58"><code>1e9d12d</code></a> go/packages: pass -overlay to all 'go list' invocations</li> <li><a href="https://github.com/golang/tools/commit/3c293ad67a98a86d273bf69c6a742f04a6a367a3"><code>3c293ad</code></a> internal/cache: invalidate broken imports when package files change</li> <li>Additional commits viewable in <a href="https://github.com/golang/tools/compare/v0.21.0...v0.22.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Commits on Jun 10, 2024
-
chore(deps-dev): Update mkdocs-material requirement from ~=9.5.25 to …
…~=9.5.26 in /gh-pages (#4540) Updates the requirements on [mkdocs-material](https://github.com/squidfunk/mkdocs-material) to permit the latest version. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/squidfunk/mkdocs-material/releases">mkdocs-material's releases</a>.</em></p> <blockquote> <h2>mkdocs-material-9.5.26</h2> <ul> <li>Fixed <a href="https://redirect.github.com/squidfunk/mkdocs-material/issues/7232">#7232</a>: Tab switches on scroll when linking tabs (9.5.19 regression)</li> <li>Fixed <a href="https://redirect.github.com/squidfunk/mkdocs-material/issues/7230">#7230</a>: Blog author avatar broken when referring to local file</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG">mkdocs-material's changelog</a>.</em></p> <blockquote> <p>mkdocs-material-9.5.26 (2024-06-06)</p> <ul> <li>Fixed <a href="https://redirect.github.com/squidfunk/mkdocs-material/issues/7232">#7232</a>: Tab switches on scroll when linking tabs (9.5.19 regression)</li> <li>Fixed <a href="https://redirect.github.com/squidfunk/mkdocs-material/issues/7230">#7230</a>: Blog author avatar broken when referring to local file</li> </ul> <p>mkdocs-material-9.5.25+insiders-4.53.11 (2024-05-27)</p> <ul> <li>Fixed projects plugin crashing when serving before building subprojects</li> </ul> <p>mkdocs-material-9.5.25 (2024-05-27)</p> <ul> <li>Fixed <a href="https://redirect.github.com/squidfunk/mkdocs-material/issues/7209">#7209</a>: Tags plugin crashing on numeric tags</li> </ul> <p>mkdocs-material-9.5.24+insiders-4.53.10 (2024-05-20)</p> <ul> <li>Fixed projects plugin crashing in serve mode when disabled</li> <li>Fixed projects plugin crashing when building nested projects</li> </ul> <p>mkdocs-material-9.5.24+insiders-4.53.9 (2024-05-20)</p> <ul> <li>Fixed <a href="https://redirect.github.com/squidfunk/mkdocs-material/issues/7191">#7191</a>: Tags listings not rendering when toc_depth is changed</li> </ul> <p>mkdocs-material-9.5.24 (2024-05-20)</p> <ul> <li>Fixed <a href="https://redirect.github.com/squidfunk/mkdocs-material/issues/7187">#7187</a>: Version selector title rendering issue</li> </ul> <p>mkdocs-material-9.5.23 (2024-05-15)</p> <ul> <li>Fixed <a href="https://redirect.github.com/squidfunk/mkdocs-material/issues/7183">#7183</a>: Edge case in anchor navigation when using instant navigation</li> <li>Fixed <a href="https://redirect.github.com/squidfunk/mkdocs-material/issues/6436">#6436</a>: Version selector not showing version alias</li> </ul> <p>mkdocs-material-9.5.22 (2024-05-12)</p> <ul> <li>Fixed <a href="https://redirect.github.com/squidfunk/mkdocs-material/issues/7170">#7170</a>: Copy button adds empty lines for line spans (9.5.18 regression)</li> <li>Fixed <a href="https://redirect.github.com/squidfunk/mkdocs-material/issues/7160">#7160</a>: Version switching doesn't stay on page (9.5.5 regression)</li> <li>Fixed <a href="https://redirect.github.com/squidfunk/mkdocs-material/issues/5619">#5619</a>: Links in Mermaid.js diagrams not discernible</li> </ul> <p>mkdocs-material-9.5.21 (2024-05-03)</p> <ul> <li>Fixed <a href="https://redirect.github.com/squidfunk/mkdocs-material/issues/7133">#7133</a>: Ensure latest version of Mermaid.js is used</li> <li>Fixed <a href="https://redirect.github.com/squidfunk/mkdocs-material/issues/7125">#7125</a>: Added warning for dotfiles in info plugin</li> </ul> <p>mkdocs-material-9.5.20 (2024-04-29)</p> <ul> <li>Fixed deprecation warning in privacy plugin (9.5.19 regression)</li> <li>Fixed <a href="https://redirect.github.com/squidfunk/mkdocs-material/issues/7119">#7119</a>: Tags plugin emits deprecation warning (9.5.19 regression)</li> <li>Fixed <a href="https://redirect.github.com/squidfunk/mkdocs-material/issues/7118">#7118</a>: Social plugin crashes if fonts are disabled (9.5.19 regression)</li> <li>Fixed <a href="https://redirect.github.com/squidfunk/mkdocs-material/issues/7085">#7085</a>: Social plugin crashes on Windows when downloading fonts</li> </ul> <p>mkdocs-material-9.5.19+insiders-4.53.8 (2024-04-26)</p> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/squidfunk/mkdocs-material/commit/f8871975babb2928ef5d797ddcc659ddf8aa19ff"><code>f887197</code></a> Updated changelog</li> <li><a href="https://github.com/squidfunk/mkdocs-material/commit/0d5a08ca9de9f97cb2302490b8ef9d451dfd17f3"><code>0d5a08c</code></a> Prepare 9.5.26 release</li> <li><a href="https://github.com/squidfunk/mkdocs-material/commit/1cc45d50d077c8c27d58b71dcc11b941779ec9b2"><code>1cc45d5</code></a> Fixed active tab stolen on scroll with linked content tabs</li> <li><a href="https://github.com/squidfunk/mkdocs-material/commit/b5b7e9d678aa82b453516d041691c5e6fa0074ab"><code>b5b7e9d</code></a> Updated dependencies</li> <li><a href="https://github.com/squidfunk/mkdocs-material/commit/c182598acd7a4a19de6095d8cefc3efd321fb77a"><code>c182598</code></a> Added distribution files</li> <li><a href="https://github.com/squidfunk/mkdocs-material/commit/49ebb9bbfa3f2ff714bdae765aa89fa51f4fc0d9"><code>49ebb9b</code></a> Improved accessibility of search partial (<a href="https://redirect.github.com/squidfunk/mkdocs-material/issues/7233">#7233</a>)</li> <li><a href="https://github.com/squidfunk/mkdocs-material/commit/5bd843be2322f074578576360e4bed857d4f509b"><code>5bd843b</code></a> Updated dependencies</li> <li><a href="https://github.com/squidfunk/mkdocs-material/commit/0fc36a1f4c90f350be7c51f5600d7f33716faa7b"><code>0fc36a1</code></a> Added support for local author avatars</li> <li><a href="https://github.com/squidfunk/mkdocs-material/commit/2412a1b7bc0713730ec3d134b26fe503d9421c41"><code>2412a1b</code></a> Documentation (<a href="https://redirect.github.com/squidfunk/mkdocs-material/issues/7221">#7221</a>)</li> <li><a href="https://github.com/squidfunk/mkdocs-material/commit/6c3f846078dcad4ae534683a7f07aac0f3955994"><code>6c3f846</code></a> Updated custom styles</li> <li>Additional commits viewable in <a href="https://github.com/squidfunk/mkdocs-material/compare/9.5.25...9.5.26">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
-
fix(python): incorrect escaped characters cause warnings (#4538)
Fixes #4532. Succinctly, the issue is that the README is copied over into the `__init__.py` file as a python comment. And then python warns that things like `\|` and `\'`, which while not often, do organically and correctly show up in markdown syntax, are invalid escapes. Some people who have set their python config to error on warnings end up erroring on this. The solution is to mark the README string as a raw string `r'''` so python does not try to register the escapes. I'm not sure how to test this in code in this PR. I have done the following to make sure that this works: I copied the repro repo from #4532 [here](https://github.com/kaizencc/cdk_invalid_char/blob/main) and got it to show the warning locally. then, I updated the actual file manually from `'''` to `r'''` and got `pytest -W error` to give me a thumbs up. So that shows that changing `'''` to `r'''` does not expect the escaped characters to be valid. I tested my local jsii-pacmak by using it to package a module in `aws-cdk`, and unzipped the python package and confirmed that the `r'''` raw string indicator shows up for the README string in `__init__.py`, and nothing else. These two combined confirms for me that this solution will work. Again I'm not sure of the best way to test that in jsii-pacmak. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.