feat: Added an interruption taint to the nodes #6143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
That way pods can look at the node to see if they were interrupted because of a spot interrupt
stijndehaes
force-pushed
the
feature/added-interruption-taints
branch
from
32382cc
to
ddeb2b1
Compare
|
Made some comments in the original issue. I'm not sure the taint is the best way to achieve this. I'd rather see you build the observability after eventing or rely on the NodeClaim status conditions and we can build-in support for adding NodeClaim status conditions on interrupt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way pods can look at the node to see if they were interrupted because of a spot interrupt
Fixes #6103
Description
Added a taint to the nodes when there is an interruption happening
How was this change tested?
Unit test
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.