Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit E2E Suite for DaemonSet Couplings #6145

Open
jmdeal opened this issue May 3, 2024 · 0 comments
Open

Audit E2E Suite for DaemonSet Couplings #6145

jmdeal opened this issue May 3, 2024 · 0 comments
Labels
automation Issues about the Karpenter's automation processes testing Issues that involve adding test coverage

Comments

@jmdeal
Copy link
Contributor

jmdeal commented May 3, 2024

The addition of several DaemonSets to our E2E clusters by #5982 caused failures across the E2E suite. These failures can be categorized into two buckets:

  1. Tests which have a deep coupling between the size of nodes and what pods will be able to schedule on those nodes (example).
  2. Tests which rely on the number of DaemonSets or the DaemonSet overhead (example). These tests were broke by the addition of GPU specific DaemonSets (see #715).

Currently, whenever a new DaemonSet is added to our E2E clusters there is a risk that tests will begin to fail for one of these reasons. We should audit our E2E suite and, when possible, eliminate these couplings. For tests where these couplings are required, we should evaluate if they need to be E2E tests or can be sufficiently covered by functional tests.

@jmdeal jmdeal added automation Issues about the Karpenter's automation processes testing Issues that involve adding test coverage labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Issues about the Karpenter's automation processes testing Issues that involve adding test coverage
Projects
None yet
Development

No branches or pull requests

1 participant