test: fix params specification (#2422)

Author: tzneal

test/suites/common/suite.yaml

@@ -52,15 +52,15 @@ spec:
       operator: in
       values:
         - "true"
-  - name: notify-build-failure # executed only when build task fails and notifications are enabled
+  - name: notify-build-failure
     when:
       - input: $(tasks.status)
         operator: in
         values: ["Failed"]
     taskRef:
       name: notify-slack
-      params:
-        - name: webhook-secret
-          value: slack-webhook-secret
-        - name: message
-          value: $(context.pipelineRun.name) has failed
+    params:
+    - name: webhook-secret
+      value: slack-webhook-secret
+    - name: message
+      value: $(context.pipelineRun.name) has failed

test/suites/upgrade/pipeline.yaml

@@ -77,3 +77,15 @@ spec:
       operator: in
       values:
         - "true"
+  - name: notify-build-failure
+    when:
+      - input: $(tasks.status)
+        operator: in
+        values: ["Failed"]
+    taskRef:
+      name: notify-slack
+    params:
+    - name: webhook-secret
+      value: slack-webhook-secret
+    - name: message
+      value: $(context.pipelineRun.name) has failed