-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unify grafana dashboard datasource by use of a variable and add new karpenter 0.15.0 consolidation graphs #2276
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I also added the new karpenter 0.15.0 consolidation metrics to the capacity dashboard |
Hi @pyromaniac3010, thanks for the contribution! Since I'm not an expert here, can you explain a little more about what a non-statically defined datasource UID does, or how this helped you for development? When you say Additionally, for the dashboard, do you mind posting some screenshots of how these look? |
Hi @njtran, in the "old" version there is a This is a screenshot of the changes made to include the new "Consolidation" metrics (including "cluster"-label): |
Hey, sorry for the delay. This looks good. I'll try it out on my cluster. Can you add a little more information on how you tested this? For instance, how did you install the helm charts? Did you import the JSON manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pyromaniac3010, the dashboard looks good to me. Tested it with the following grafana-values.yaml
to reflect your newer commit. Looks like it works with or without the datasource: Prometheus
part, so going to approve as it looks good as is.
dashboards:
default:
capacity-dashboard:
url: https://raw.githubusercontent.com/pyromaniac3010/karpenter/04c1fcb6c54a1b320ebbbb90ea388563493a67b7/website/content/en/preview/getting-started/getting-started-with-eksctl/karpenter-capacity-dashboard.json
datasource: Prometheus
performance-dashboard:
url: https://raw.githubusercontent.com/pyromaniac3010/karpenter/04c1fcb6c54a1b320ebbbb90ea388563493a67b7/website/content/en/preview/getting-started/getting-started-with-eksctl/karpenter-performance-dashboard.json
datasource: Prometheus
Thanks for the contribution!
Get rid of statically assigned datasource uid. This enables users to import the dashboard to kube-prometheus-stack without altering it afterwards to search and replace the datasource uid.
How was this change tested?
using grafana config in kube-prometheus stack with my version results in directly showing graphs. With the old version it shows errors about not found datasource.
Does this change impact docs?
Release Note
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.