fix: reduce pod nomination event counts #2384
Merged
+75
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These aren't useful during large scale-ups, so drop them instead of loading the API server. The case where these are useful is if we believe a pod will schedule, but kube-scheduler won't. In this case, the pod nominations will be repeated indefinitely and will be available on the pod.
|
I could be convinced there is a better way to do this. |
✅ Deploy Preview for karpenter-docs-prod canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These aren't useful during large scale-ups, so drop them instead
of loading the API server. The case where these are useful is
if we believe a pod will schedule, but kube-scheduler won't. In
this case, the pod nominations will be repeated indefinitely and
will be available on the pod.
How was this change tested?
Does this change impact docs?
Release Note
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.