Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove comment after wait command #2429

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Conversation

eichlerr
Copy link
Contributor

The comment after the wait command causes the helm upgrade command to fail with the following message:

Error: "helm upgrade" requires 2 arguments

Removing the comment fixes this error.

Fixes # NA

Description
This is a fix to the helm upgrade script in the getting started documentation. The documentation doesn't make it clear that users should remove this comment before running the command/script, otherwise it will fail.

How was this change tested?

  • Removing the comment after the last command in the script resolved my issue.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

This is a change to the Getting Started document where developers could experience issues trying to install the Helm chart needed for Karpenter.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sorry, something went wrong.

The comment after the wait command causes the `helm upgrade` command to fail with the following message:
> Error: "helm upgrade" requires 2 arguments

Removing the comment fixes this error.
@eichlerr eichlerr requested a review from a team as a code owner August 31, 2022 20:01
@eichlerr eichlerr requested a review from spring1843 August 31, 2022 20:01
@netlify
Copy link

netlify bot commented Aug 31, 2022

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit c087363
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/630fbdff293f300008735d5a
😎 Deploy Preview https://deploy-preview-2429--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@jonathan-innis jonathan-innis merged commit 3a4b0ba into aws:main Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants