feat: Added evictionHard, kubeReserved and podsPerCore to Provisioner
#2444
+762
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
tzneal
reviewed
Sep 8, 2022
| if e.KubeletConfig != nil && e.KubeletConfig.MaxPods != nil { | ||
| userData.WriteString(" \\\n--use-max-pods false") | ||
| kubeletExtraArgs += fmt.Sprintf(" --max-pods=%d", ptr.Int32Value(e.KubeletConfig.MaxPods)) | ||
| } else if !e.AWSENILimitedPodDensity { | ||
| userData.WriteString(" \\\n--use-max-pods false") | ||
| kubeletExtraArgs += " --max-pods=110" | ||
| } | ||
| if e.KubeletConfig != nil && e.KubeletConfig.PodsPerCore != nil { | ||
| kubeletExtraArgs += fmt.Sprintf(" --pods-per-core=%d", ptr.Int32Value(e.KubeletConfig.PodsPerCore)) |
There was a problem hiding this comment.
@bwagner5 Wasn't there some weird issue earlier this year with the eks bootstrap script and setting values using an = sign?
E.g.
--pods-per-core 50 vs --pods-per-core=50
There was a problem hiding this comment.
Found the old issue, #1520 , it's only the bootstrap args that it causes problems with.
There was a problem hiding this comment.
^^ yep, kubelet args will work fine w/ =
bwagner5
requested changes
Sep 9, 2022
|
Does it make sense to support soft eviction thresholds as well? |
It probably does, I figured we could decouple these for now, but we should probably follow-up this PR with support for |
jonathan-innis
force-pushed
the
added-kubelet-config
branch
2 times, most recently
from
6a2077b to
0d9cf51
Compare
jonathan-innis
force-pushed
the
added-kubelet-config
branch
2 times, most recently
from
2b5e0d9 to
6766f31
Compare
jonathan-innis
force-pushed
the
added-kubelet-config
branch
from
6766f31 to
cfe75cb
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2129
Description
evictionHard,kubeReservedandpodsPerCorein Provisioner specHow was this change tested?
make testTEST_FILTER="integration" make e2etestsDoes this change impact docs?
Release Note
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.