Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

While using Custome AMI, Controller Role cannot describe images #2470

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

iflan7744
Copy link
Contributor

@iflan7744 iflan7744 commented Sep 7, 2022

Fixes #

Description
While using Launch Template with Custom AMI the controller role cannot describe the AMI image ID and create Instance out of it.

How was this change tested?
I include ec2:DescribeImages to KarpenterControllerPolicy and Karpenter created the Instance with custom AMI.
*

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

NONE

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sorry, something went wrong.

@iflan7744 iflan7744 requested a review from a team as a code owner September 7, 2022 06:29
@netlify
Copy link

netlify bot commented Sep 7, 2022

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 72b5c91
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/63183a30b8a22100085e1e3f
😎 Deploy Preview https://deploy-preview-2470--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jonathan-innis
Copy link
Contributor

Thanks @iflan7744 for your proposed contribution! We are thinking it might be better to rely on cloudformation rather than having two separate places in the docs where we manage policy definitions, to point to the same location across the docs. i.e. we have a policy definition defined in cloudformation here.

If we could reference this cloudformation policy (similar to how it's referenced here) and then add the detail of the OIDC trust policy relationship, we could cut down on docs duplication quite a bit!

@jonathan-innis jonathan-innis self-assigned this Sep 13, 2022
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis
Copy link
Contributor

Unblocking some users by taking this change in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants