Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Use daemonset count to calculate maxPods and podsPerCore #2497

Merged

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Sep 13, 2022

Fixes #

Description

  • Number of DS in integration tests aren't consistent between environments. DS count should be used to determine the DS pod overhead.

How was this change tested?

  • TEST_FILTER=Integration make e2etests

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sorry, something went wrong.

@jonathan-innis jonathan-innis requested a review from a team as a code owner September 13, 2022 06:58
@netlify
Copy link

netlify bot commented Sep 13, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 48b3f22
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6320ad7d08f9480009a2d04a

@jonathan-innis jonathan-innis force-pushed the kubelet-configuration-integration-fix branch 2 times, most recently from 0ca60b7 to ed0b1b0 Compare September 13, 2022 15:30
@jonathan-innis jonathan-innis force-pushed the kubelet-configuration-integration-fix branch from ed0b1b0 to 48b3f22 Compare September 13, 2022 16:19
Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonathan-innis jonathan-innis merged commit 436374b into aws:main Sep 13, 2022
@jonathan-innis jonathan-innis deleted the kubelet-configuration-integration-fix branch September 13, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants