Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix integration test monitor flakiness #2509

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Sep 14, 2022

Fixes #

Description

  • Fixes failures due to calling env.Monitor.Reset() within a test
  • Ignores pods that are Terminating for scheduling

How was this change tested?

  • TEST_FILTER=Integration make e2etests

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sorry, something went wrong.

@jonathan-innis jonathan-innis requested a review from a team as a code owner September 14, 2022 17:39
@netlify
Copy link

netlify bot commented Sep 14, 2022

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit ca8b4ef
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/632211df411ad9000847c7be
😎 Deploy Preview https://deploy-preview-2509--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonathan-innis jonathan-innis merged commit 7c99dc2 into aws:main Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants